Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependency-submission: skip test scope #1392

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/dependency-graph.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ jobs:
contents: write
steps:
- uses: actions/checkout@v4
- uses: scalacenter/sbt-dependency-submission@v2
- uses: scalacenter/sbt-dependency-submission@v3
with:
configs-ignore: test
14 changes: 1 addition & 13 deletions project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ object Dependencies {
// needs to be inline with the aeron version, check
// https://github.com/real-logic/aeron/blob/1.x.y/build.gradle
val agronaVersion = "1.21.1"
val bouncyCastleVersion = "1.78.1"
val nettyVersion = "4.1.112.Final"
val logbackVersion = "1.3.14"

Expand Down Expand Up @@ -119,13 +118,8 @@ object Dependencies {
}

object TestDependencies {
val bcprov = "org.bouncycastle" % "bcprov-jdk18on" % bouncyCastleVersion % Test
val bcpkix = "org.bouncycastle" % "bcpkix-jdk18on" % bouncyCastleVersion % Test
val bcutil = "org.bouncycastle" % "bcutil-jdk18on" % bouncyCastleVersion % Test
val commonsIo = "commons-io" % "commons-io" % "2.16.1" % Test
val commonsCodec = "commons-codec" % "commons-codec" % "1.17.1" % Test
val commonsCompress = "org.apache.commons" % "commons-compress" % "1.26.2" % Test
val guava = "com.google.guava" % "guava" % "33.2.1-jre" % Test
val junit = "junit" % "junit" % junitVersion % Test
val junit5 = "org.junit.jupiter" % "junit-jupiter-engine" % junit5Version % Test
val httpClient = "org.apache.httpcomponents" % "httpclient" % "4.5.14" % Test
Expand All @@ -150,16 +144,10 @@ object Dependencies {
// in-memory filesystem for file related tests
val jimfs = "com.google.jimfs" % "jimfs" % "1.3.0" % Test

// the extra dependency overrides for bcprov, commonsCompress and guava should be reviewed - https://github.com/apache/pekko/issues/1317
val dockerClientVersion = "3.4.0"
val dockerClient = Seq(
"com.github.docker-java" % "docker-java-core" % dockerClientVersion % Test,
"com.github.docker-java" % "docker-java-transport-httpclient5" % dockerClientVersion % Test,
TestDependencies.bcprov,
TestDependencies.bcpkix,
TestDependencies.bcutil,
TestDependencies.commonsCompress,
TestDependencies.guava)
"com.github.docker-java" % "docker-java-transport-httpclient5" % dockerClientVersion % Test)

val jackson = Seq(
jacksonCore % Test,
Expand Down