feat: Make SingleConsumerMultiProducer the default mailbox for stream. #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Jan 8, 2024
pjfanning
reviewed
Jan 8, 2024
stream/src/main/scala/org/apache/pekko/stream/impl/ActorMaterializerImpl.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Jan 8, 2024
stream/src/main/scala/org/apache/pekko/stream/impl/PhasedFusingActorMaterializer.scala
Outdated
Show resolved
Hide resolved
laglangyue
reviewed
Jan 8, 2024
stream/src/main/scala/org/apache/pekko/stream/impl/ActorMaterializerImpl.scala
Show resolved
Hide resolved
laglangyue
reviewed
Jan 8, 2024
stream/src/main/scala/org/apache/pekko/stream/impl/PhasedFusingActorMaterializer.scala
Show resolved
Hide resolved
|
It seems that a default configuration has been added. Are there any unit test? |
|
@laglangyue I don't this this code need any test, and a test may need another pr first:), you can try with a debuger to see the mailboxtype. |
|
lgtm |
|
@mdedetrich Would you like to give this a review? this was landed in Akka 2.7 |
mdedetrich
approved these changes
Jan 10, 2024
|
@mdedetrich Not easy to test, that's why I want the #919 . and I did confirm that works with debuger. |
No worries, I approved the PR anyways so its good from my end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Make stream actor using the SingleConsumerMultiProducer by default for performance.
refs: #915