Move configuration defaults out of base-box definition and into plugin #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2014 09:23
Putting the defaults in the provider plugin gives it a chance to set up default values before a Vagrant box has been downloaded and installed. Also, some new environment variables are checked now, which are taken from Joyent's SmartDataCenter CLI tools. The traditional environment variables are checked and still take precedence. Config value | Original env vars | New env vars --------------+-------------------------------+-------------- username | JOYENT_USERNAME | SDC_ACCOUNT keyname | (n/a) | SDC_KEY_ID keyfile | JOYENT_SSH_PRIVATE_KEY_PATH | SDC_KEY password | JOYENT_PASSWORD | (n/a) api_url | JOYENT_API_URL | SDC_URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that having the plugin rely on a base box for default values creates a "chicken and egg" problem when the box is not yet installed.
I've fixed this up and also taken the liberty of having the plugin recognize
SDC_*environment variables used by Joyent's SmartDataCenter CLI tools. I've rewritten the configuration documentation to explain this.