Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature app core #2

Open
wants to merge 15 commits into
base: feature-app-core
Choose a base branch
from

Conversation

YonasJ
Copy link

@YonasJ YonasJ commented Apr 10, 2020

A couple of changes I hope you can add to your active trunk.

  1. I updated your gpio file so that open drain pins have the ability to read and write, and I model that in the bitbang.rs example I added.
  2. I added a struct called "Console" that I use to do safe(?) println! from the examples. I demo this in the example hello.rs
  3. I added an example called button that shows using GPIO for input.
  4. I added a file called "watchdog_disabler" which I use to cleanly disable the watchdog in the examples.

It's probably not perfect, as I am still learning rust, but it's a step in the right direction.

Once I figure out how to implement an interrupt handler on GPIO change, I should be ready to roll for the app I am working on.

@arjanmels
Copy link
Owner

@YonasJ Thanks for contributing. I think this pull request should go directly to the esp-rs/esp-hal repo and not my fork of it. Because then we still need to get this fork merged.

You have some nice examples. (I personally hesitate if your console.rs and watchdog_disable should go into the esp32-hal: they are higher level and specific.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants