forked from esp-rs/esp32-hal
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature app core #2
Open
YonasJ
wants to merge
15
commits into
arjanmels:feature-app-core
Choose a base branch
from
YonasJ:feature-app-core
base: feature-app-core
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature-app-core
…s a macro called dprint which makes the use statement seem odd.
…t! and println! (to help it feel more like normal/usable esp32 dev)
…g this because there seems to be an issue when the GPIO is held high on boot?
Also update examples to match, including a new example, bitbang, that demos it. And includes the types, which can be difficult to figure out.
arjanmels
force-pushed
the
feature-app-core
branch
from
April 14, 2020 20:53
5f73eea
to
44bd68a
Compare
@YonasJ Thanks for contributing. I think this pull request should go directly to the esp-rs/esp-hal repo and not my fork of it. Because then we still need to get this fork merged. You have some nice examples. (I personally hesitate if your console.rs and watchdog_disable should go into the esp32-hal: they are higher level and specific.) |
arjanmels
force-pushed
the
feature-app-core
branch
from
April 24, 2020 10:13
7b9cdd1
to
1693b88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes I hope you can add to your active trunk.
It's probably not perfect, as I am still learning rust, but it's a step in the right direction.
Once I figure out how to implement an interrupt handler on GPIO change, I should be ready to roll for the app I am working on.