Merge pull request biolab#1861 from nikicc/imageviewer-fix-indexing

[FIX] OWImageViewer: Fix selection with missing values (cherry picked from commit 04be225)
astaric · Jan 10, 2017 · 7638fb2 · 7638fb2
1 parent a0817f3
commit 7638fb2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Orange/widgets/data/owimageviewer.py b/Orange/widgets/data/owimageviewer.py
@@ -991,12 +991,12 @@ def setupScene(self):
         if self.data:
             attr = self.stringAttrs[self.imageAttr]
             titleAttr = self.allAttrs[self.titleAttr]
-            instances = [inst for inst in self.data
-                         if numpy.isfinite(inst[attr])]
             assert self.thumbnailView.count() == 0
             size = QSizeF(self.imageSize, self.imageSize)
 
-            for i, inst in enumerate(instances):
+            for i, inst in enumerate(self.data):
+                if not numpy.isfinite(inst[attr]):  # skip missing
+                    continue
                 url = self.urlFromValue(inst[attr])
                 title = str(inst[titleAttr])