refactor: remove mtree as the default output #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
no_mtree_output
branch
from
a2b9163
to
0fd5b93
Compare
thesayyn
force-pushed
the
no_mtree_output
branch
from
0fd5b93
to
8018bc9
Compare
thesayyn
changed the title
alexeagle
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
It's unfortunate that we make a breaking change in an RC phase, but we haven't seen anybody using this output so far.
Removal of the mtree as the default output allows
$(location :oci_load_label)to return theexecutableinstead of theDefaultInfo.files[0]which what most expect.