Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASSET-22] Add top100 tokens' information from Ethereum Etherscan #23

Merged
merged 2 commits into from
May 14, 2024

Conversation

jormal
Copy link
Collaborator

@jormal jormal commented May 13, 2024

Pull Request

Description

Ethereum network의 etherscan에서의 top100 token을 수집합니다.
Puller 알고리즘 상 잘못 다운로드 된 몇몇 이미지에 대하여 우선 추가하지 않는 방향으로 진행했고, 추후 알고리즘 재정비 후 이미지 추가 예정입니다.

Related issue: ASSET-22

Changes

  • 1a072bc: Token 정보들 추가
  • e33137d: 잘못된 이미지 제거.

Types of Changes (multiple options can be selected)

  • Create asset information
  • Update asset information
  • Delete asset information
  • Other {{Please add description here}}

Checklist

  • Did you pass the tests?
  • Did you run the pre-process?
  • Have you added and run tests to validate the changes?
  • Have you updated the documentation?
  • Have you updated the version in setup.py if you need?

@jormal jormal added the asset_create Create the asset information label May 13, 2024
@jormal jormal self-assigned this May 13, 2024
@jormal jormal marked this pull request as ready for review May 14, 2024 01:07
@jormal jormal requested a review from a team as a code owner May 14, 2024 01:07
Copy link

@yjkellyjoo yjkellyjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큰 사이즈 이미지는 생각보다 많이 안구해지네요.. 이러면 결국 수작업으로 큰 사이즈들을 구해야하는 일이 많아지진 않을지 걱정이군요

@jormal
Copy link
Collaborator Author

jormal commented May 14, 2024

큰 사이즈 이미지는 생각보다 많이 안구해지네요.. 이러면 결국 수작업으로 큰 사이즈들을 구해야하는 일이 많아지진 않을지 걱정이군요

원래 svg 이미지와 큰 사이즈 이미지는 필요시 디자인팀에서 직접 만들어주셔왔었고, 기존 asset info에서는 32x32사이즈를 upscaling해서 품질 낮은 이미지로 사용하곤 했었습니다. info수집을 한다는 데에 초점을 맞추어야 할 듯합니다.

@jormal jormal merged commit 8155fca into main May 14, 2024
1 check passed
@jormal jormal deleted the feature/ASSET-22 branch May 14, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset_create Create the asset information
Development

Successfully merging this pull request may close these issues.

3 participants