[ASSET-9] Add image preprocess #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jormal <[email protected]>
Signed-off-by: jormal <[email protected]>
Signed-off-by: jormal <[email protected]>
Signed-off-by: jormal <[email protected]>
auto-assign
bot
requested review from
gihyeonsung,
oh51dy,
yjkellyjoo and
zibersaioros
yjkellyjoo
approved these changes
Jan 17, 2024
jormal
added a commit
that referenced
this pull request
Jan 18, 2024
* [ASSET-9] Add info.json files (#4) * ASSET-9 Add ethereum info * ASSET-9 Add optimism info * ASSET-9 Edit git ignore file Signed-off-by: jormal <[email protected]> * ASSET-9 Reformat the svg codes Signed-off-by: jormal <[email protected]> * ASSET-9 Fix to fit with JSON scheme Signed-off-by: jormal <[email protected]> * ASSET-9 Add bsc info Signed-off-by: jormal <[email protected]> * ASSET-9 Add polygon info Signed-off-by: jormal <[email protected]> * ASSET-9 Fix the property name Signed-off-by: jormal <[email protected]> * ASSET-9 Add Klaytn info Signed-off-by: jormal <[email protected]> * ASSET-9 Add Bifrost info Signed-off-by: jormal <[email protected]> * ASSET-9 Add Base info Signed-off-by: jormal <[email protected]> * ASSET-9 Add Arbitrum info Signed-off-by: jormal <[email protected]> * ASSET-9 Add Avalanche info Signed-off-by: jormal <[email protected]> * ASSET-9 Add protocol info Signed-off-by: jormal <[email protected]> * ASSET-9 Add unknown info and add asset name Signed-off-by: jormal <[email protected]> * ASSET-9 Add enum values and descriptions Signed-off-by: jormal <[email protected]> * ASSET-9 Fix optimism icon Signed-off-by: jormal <[email protected]> * ASSET-9 Fix URL of Bifrost Bridge to apply @yjkellyjoo's comment Signed-off-by: jormal <[email protected]> * ASSET-9 Add protocol tag enum to apply @yjkellyjoo's comment Signed-off-by: jormal <[email protected]> --------- Signed-off-by: jormal <[email protected]> * [ASSET-9] Define models and add tests (#5) * ASSET-9 Add model of information Signed-off-by: jormal <[email protected]> * ASSET-9 Add validation test for each model Signed-off-by: jormal <[email protected]> * ASSET-9 Fix wrong info Signed-off-by: jormal <[email protected]> * ASSET-9 Add CI workflow Signed-off-by: jormal <[email protected]> --------- Signed-off-by: jormal <[email protected]> * [Asset-9] Add image preprocess (#6) * ASSET-9 Refactor image preprocess Signed-off-by: jormal <[email protected]> * ASSET-9 Refine image validation Signed-off-by: jormal <[email protected]> * ASSET-9 Refine ID's regex pattern Signed-off-by: jormal <[email protected]> * ASSET-9 Chore edit Signed-off-by: jormal <[email protected]> --------- Signed-off-by: jormal <[email protected]> --------- Signed-off-by: jormal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Image 추가 시 수행할 수 있는 preprocessing script를 추가하고,
Image validation test를 강화합니다.
Related issue: ASSET-9
Changes
Types of Changes (multiple options can be selected)
Setting updateChecklist