Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NODE-101, prefix: staking update #46

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

NODE-101, prefix: staking update #46

wants to merge 37 commits into from

Conversation

SunoukMun
Copy link

Description

  • fix nomination unbonding & withdrawl
  • fix candidate voting power

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Something else (simple changes that are not related to existing functionality or others)

Checklist

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have made new test codes regarding to my changes.
  • I have no personal secrets or credentials described on my changes.
  • I have run cargo-clippy and linted my code.
  • My changes generate no new warnings.
  • My changes passed the existing test codes.
  • My changes are able to compile.

@SunoukMun SunoukMun changed the title prefix, staking update NODE 101, prefix, staking update Apr 12, 2024
@SunoukMun SunoukMun changed the title NODE 101, prefix, staking update NODE 101, prefix: staking update Apr 12, 2024
@dnjscksdn98 dnjscksdn98 added the enhancement New feature or request label Apr 19, 2024
dnjscksdn98
dnjscksdn98 reviewed Apr 19, 2024
View reviewed changes
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/pallet/mod.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
runtime/dev/src/lib.rs Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
dnjscksdn98
dnjscksdn98 reviewed Apr 22, 2024
View reviewed changes
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Outdated Show resolved Hide resolved
pallets/bfc-staking/src/lib.rs Show resolved Hide resolved
@dnjscksdn98
Copy link
Member

제 생각에는 이러한 정책으로 가게 될거라면, revoke와 decrease 뿐만 아니라 leave도 함께 수정이 필요할거 같긴 하네요

@SunoukMun
Copy link
Author

SunoukMun commented Apr 22, 2024 •
edited by jira bot
Loading

제 생각에는 이러한 정책으로 가게 될거라면, revoke와 decrease 뿐만 아니라 leave도 함께 수정이 필요할거 같긴 하네요

이 부분에 대해서는 NODE-107 에 추가하였습니다

@pilab-gwon pilab-gwon changed the title NODE 101, prefix: staking update NODE-101, prefix: staking update Apr 22, 2024
SunoukMun and others added 19 commits April 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnjscksdn98 dnjscksdn98 dnjscksdn98 left review comments

@alstjd0921 alstjd0921 Awaiting requested review from alstjd0921 alstjd0921 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@SunoukMun SunoukMun

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunoukMun @dnjscksdn98