Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWCorrelations: Use heuristic to get the most promising attribute pairs #70

Merged
merged 10 commits into from
Oct 5, 2018

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Mar 16, 2017

When dataset is too big (i.e too many attributes or instances), it is impossible to calculate correlations for all attribute pairs. KMeans is used to suggest the most promising attribute pairs by selecting the pair within a cluster.

@BlazZupan
Copy link
Contributor

Please sort the rows by absolute value of correlations. Also, keep the same precision when displaying numbers (e.g., instead of 0.76 write 0.760).

@BlazZupan
Copy link
Contributor

Please show progress bar.

@VesnaT VesnaT force-pushed the owcorrelations_heuristic branch 2 times, most recently from 7542d5c to ab5b72c Compare March 17, 2017 14:36
@VesnaT VesnaT changed the title OWCorrelations: Use heuristic to get the most promising attribute pairs [WIP] OWCorrelations: Use heuristic to get the most promising attribute pairs Mar 17, 2017
@VesnaT
Copy link
Contributor Author

VesnaT commented Mar 17, 2017

Do not merge until
biolab/orange3#2117 and
biolab/orange3#2118
are merged.

@VesnaT VesnaT force-pushed the owcorrelations_heuristic branch 2 times, most recently from d9479ed to 7b1b503 Compare March 24, 2017 14:30
@VesnaT VesnaT changed the title [WIP] OWCorrelations: Use heuristic to get the most promising attribute pairs OWCorrelations: Use heuristic to get the most promising attribute pairs Mar 27, 2017
@ajdapretnar
Copy link
Contributor

Since both necessary commits are merged, can we merge this one as well? @BlazZupan

@astaric
Copy link
Member

astaric commented Jun 26, 2018

@BlazZupan, this has been sitting here for more than a year. Is there still need for this widget? Do we ask @VesnaT to rebase, or do we close it as won't fix?

@ajdapretnar
Copy link
Contributor

@VesnaT Could you please rebase so we can merge and hopefully include it in the migration of the widget? Thanks!

@BlazZupan
Copy link
Contributor

It would be great if we can have this widget finally in Orange.

@VesnaT
Copy link
Contributor Author

VesnaT commented Jul 31, 2018

It's rebased, but the tests don't pass (I guess since vizrank has been changed). The tests should be fixed before the widget is moved to Orange.

@ajdapretnar
Copy link
Contributor

Yeah, it's probably #155.

@VesnaT
Copy link
Contributor Author

VesnaT commented Jul 31, 2018

The last commit fixes #155

@ajdapretnar
Copy link
Contributor

I have tried this and while it looks really good, I am getting a segfault when switching between Pearson and Spearman. I cannot easily replicate this, but it happens each and every time when using iris.tab, clicking on different feature pairs and switching between Pearson and Spearman. Normally I select a feature pair and then switch the method.

@ajdapretnar ajdapretnar merged commit f3772cf into biolab:master Oct 5, 2018
@ajdapretnar
Copy link
Contributor

I merged this. I will have a look at the segfault issue and try to have it as replicable as possible. This will be a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants