Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenate widget: no union of attributes #1865

Closed
markotoplak opened this issue Jan 4, 2017 · 2 comments
Closed

Concatenate widget: no union of attributes #1865

markotoplak opened this issue Jan 4, 2017 · 2 comments
Assignees

Comments

@markotoplak
Copy link
Member

Orange version

At least 3.3.8+, also affects master

Expected behavior

Given two different data sets to Concatenate and chosen option to output union of attributes would make a new data set with domain containing attributes from both data sets.

Actual behavior

Only attributes from the primary data set are on the output.

@markotoplak markotoplak self-assigned this Jan 4, 2017
@markotoplak markotoplak added the bug A bug confirmed by the core team label Jan 4, 2017
@markotoplak
Copy link
Member Author

Hmmm, looking at the widget text this seems like this was actually a feature.

@markotoplak
Copy link
Member Author

So the widget works as follows: union (or intersection) of features only works when there are no Primary Data. If there are Primary data, its domain is always used for the concatenated data set. Which was at least for me not what I expected when I sloppily used this widget. To make this clearer I propose deactivating "Domain Merging" box when "Primary Data" is on input in #1886. I also changed default inputs to "Additional Data".

I think the best would be to rename the multiple input "Additional data" to "Data" and "Primary Data" to "Domain" (and only use the Domain of the data set connected to this input). Because this would break compatibility of saved schemas, I propose this change for a new feature release.

@markotoplak markotoplak added wishlist and removed bug A bug confirmed by the core team labels Jan 12, 2017
@janezd janezd closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants