[FIX] Concatenate bugfix #1886
Merged
[FIX] Concatenate bugfix #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.25% (diff: 100%)@@ master #1886 diff @@
==========================================
Files 86 86
Lines 9100 9100
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8122 8122
Misses 978 978
Partials 0 0
|
lanzagar
reviewed
Jan 9, 2017
| @@ -64,7 +64,7 @@ def __init__(self): | |||
| self.primary_data = None | |||
| self.more_data = OrderedDict() | |||
|
|
|||
| mergebox = gui.vBox(self.controlArea, "Domain Merging") | |||
| self.mergebox = mergebox = gui.vBox(self.controlArea, "Domain Merging") | |||
There was a problem hiding this comment.
mergebox is only used once, so instead of defining it, you could just use self.mergebox in L69.
Simpler and in this case even shorter.
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 10, 2017
[FIX] Concatenate bugfix (cherry picked from commit aafacce)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 11, 2017
[FIX] Concatenate bugfix (cherry picked from commit aafacce)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 13, 2017
[FIX] Concatenate bugfix (cherry picked from commit aafacce)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
[FIX] Concatenate bugfix (cherry picked from commit aafacce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1872, #1869, and tries to fix a usability problem in #1865 by saner defaults and by deactivating a part of the widget settings that are not used in certain input combinations.
Includes