OWNeighbors: check matching of attributes only

[ajdapretnar]

Describe the bug
Neighbors widget doesn't work when meta attributes are different. Should probably only check if X matches, since it doesn't consider metas anyway.

To Reproduce
Steps to reproduce the behavior:

1. Import Images - Image Embedding.
2. Import Images - Face Detector - Image Embedding.
3. Send both to Neighbors.

Orange version:
3.23.1

Expected behavior
If attributes of both outputs match (data.domain.attributes == reference_data.domain.attributes), Neighbors works.

[ajdapretnar]

This seems to be already fixed a long time ago in #3555.
However, the domain matching fails on the latest release. Not on master. I suspect Variable.make has something to do with this.

[ajdapretnar]

I think a release of the current master should fix this. A test would be nice. Domains have to come from two different sources I think - Image Embedding works well for testing.

[PrimozGodec]

I assume that it must be the same bug than at #4108 since both use a domain.transform. Also, the test is already available:

orange3/Orange/widgets/data/tests/test_owneighbors.py

Lines 402 to 457 in 5febf5f

	def test_different_metas(self):
	"""
	Test weather widget do not show error when data and a reference have
	domain that differ only in metas
	"""
	w = self.widget
	domain = Domain([ContinuousVariable("a"), ContinuousVariable("b")],
	metas=[ContinuousVariable("c")])
	data = Table(
	domain, np.random.rand(2, len(domain.attributes)),
	metas=np.random.rand(2, len(domain.metas)))
	# same domain with same metas no error
	self.send_signal(w.Inputs.data, data)
	self.send_signal(w.Inputs.reference, data[:1])
	self.assertFalse(w.Error.diff_domains.is_shown())
	# same domain with different metas no error
	domain_ref = Domain(domain.attributes,
	metas=[ContinuousVariable("d")])
	reference = Table(
	domain_ref, np.random.rand(1, len(domain_ref.attributes)),
	metas=np.random.rand(1, len(domain.metas)))
	self.send_signal(w.Inputs.data, data)
	self.send_signal(w.Inputs.reference, reference)
	self.assertFalse(w.Error.diff_domains.is_shown())
	# same domain with different order - no error
	domain_ref = Domain(domain.attributes[::-1])
	reference = Table(
	domain_ref, np.random.rand(1, len(domain_ref.attributes)))
	self.send_signal(w.Inputs.data, data)
	self.send_signal(w.Inputs.reference, reference)
	self.assertFalse(w.Error.diff_domains.is_shown())
	# same domain with different number of metas no error
	domain_ref = Domain(
	domain.attributes,
	metas=[ContinuousVariable("d"), ContinuousVariable("e")])
	reference = Table(
	domain_ref, np.random.rand(1, len(domain_ref.attributes)),
	metas=np.random.rand(1, len(domain_ref.metas)))
	self.send_signal(w.Inputs.data, data)
	self.send_signal(w.Inputs.reference, reference)
	self.assertFalse(w.Error.diff_domains.is_shown())
	# different domain with same metas - error shown
	domain_ref = Domain(domain.attributes + (ContinuousVariable("e"),),
	metas=[ContinuousVariable("c")])
	reference = Table(
	domain_ref, np.random.rand(1, len(domain_ref.attributes)),
	metas=np.random.rand(1, len(domain_ref.metas)))
	self.send_signal(w.Inputs.data, data)
	self.send_signal(w.Inputs.reference, reference)
	self.assertTrue(w.Error.diff_domains.is_shown())

In #4131 I made a small addition to the test to also checks the output.

[ajdapretnar]

If tests are already available, I can't understand how they could pass with the last release... Neighbors now doesn't work for demo workflow (lookalike).

[PrimozGodec]

You are right, those tests didn't exactly cover the issue you had. The problem was that in this case, all attributes have the same names are different objects. I added a test case for that in #4131.

[ajdapretnar]

Yeah, that was the case. Thanks!