Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neighbours additional tests for different domains #4131

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Oct 22, 2019

Issue

Fixes #4117

Description of changes

This PR implements a small addition to tests based on #4117

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar
Copy link
Contributor

This looks ok, but you need to update tests, too. Travis is unhappy.

@PrimozGodec PrimozGodec force-pushed the neighbours-remove-info branch 2 times, most recently from 9730280 to 197d1f9 Compare October 23, 2019 10:30
@PrimozGodec PrimozGodec changed the title [WIP] Neighbours remove info and update tests Neighbours additional tests for different domains Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #4131 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4131      +/-   ##
==========================================
+ Coverage   85.66%   85.66%   +<.01%     
==========================================
  Files         389      389              
  Lines       69648    69669      +21     
==========================================
+ Hits        59667    59685      +18     
- Misses       9981     9984       +3

@janezd janezd merged commit 1fb5f8a into biolab:master Oct 23, 2019
@PrimozGodec PrimozGodec deleted the neighbours-remove-info branch October 31, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OWNeighbors: check matching of attributes only
3 participants