[FIX] PCA: Fix the variance spin. #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.77%@@ master #1396 diff @@
==========================================
Files 75 75
Lines 7434 7434
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6525 6525
Misses 909 909
Partials 0 0
|
|
|
||
| def _on_cut_changed(self, line): | ||
| # cut changed by means of a cut line over the scree plot. | ||
| value = int(round(line.value())) | ||
| value = int(line.value()) |
There was a problem hiding this comment.
I don't like this change: the value should be rounded, not rounded down.
|
I understand why three decimals -- to explain the difference due to rounding. I don't understand what was wrong with the line. Can you tell me how to reproduce the problem that this PR fixes? |
|
The displayed number of components does not match with the cut line (it's sometimes off by one) when changing the variance spin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.