[FIX] PaintData: Sends None when the paint includes no data points #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.90%@@ master #1425 diff @@
==========================================
Files 77 77
Lines 7531 7531
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6620 6620
Misses 911 911
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the widget would send out the data table despite not including any data instances. This happens, for example, when sending the data is set to automatic (every change is committed) and the user removes all the data. With the empty data sets, some of Orange's widget crash (a problem on its own), so it is safer and according to convention in Orange to send None if the data set is empty.