[FIX] Predictions: column size hint #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default QTableView.sizeHintForColumn can iterate over the entire model's contents, which can be unforgivingly slow for large models. In particular this happens when the `sizeHintForColumn` is called while the view is not visible. (fixes biolabgh-1512)
Current coverage is 88.26% (diff: 100%)@@ master #1514 diff @@
==========================================
Files 77 77
Lines 7624 7624
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6729 6729
Misses 895 895
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement sizeHintForColumn
The default QTableView.sizeHintForColumn can iterate over the entire
model's contents, which can be unforgivingly slow for large models.
In particular this happens when the
sizeHintForColumnis called whilethe view is not visible.