[FIX] Stats: Fix counting of missing values for non-numeric data #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats returned negative numbers of nans on non-numberic data (metas). Hence, for metas, table widget always showed 'no missing values'. The problem was in priorities. We should first negate binary array and only then sum. Without brackets binary array was first summed and only then ~ was applied. On integers ~ returns -(x+1) which lead to negative values.
Current coverage is 88.66% (diff: 100%)@@ master #1585 diff @@
==========================================
Files 78 78
Lines 8111 8111
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7192 7192
Misses 919 919
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stats returned negative numbers of nans on non-numberic data (metas). Hence, for metas, table widget always showed 'no missing values'. The problem was in priorities. We should first negate binary array and only then sum. Without brackets binary array was first summed and only then ~ was applied. On integers ~ returns -(x+1) which lead to negative values.