[ENH] SQL Server support in SQL widget #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.68% (diff: 72.36%)@@ master #1674 diff @@
==========================================
Files 79 82 +3
Lines 8603 8779 +176
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7691 7786 +95
- Misses 912 993 +81
Partials 0 0
|
astaric
force-pushed
the
refactor-sql
branch
7 times, most recently
from
9dd0e08
to
7ca9c54
Compare
astaric
force-pushed
the
refactor-sql
branch
2 times, most recently
from
71253d9
to
1082c6a
Compare
astaric
changed the title
|
I have no idea how to test mssql on travis, since the database is not provided there, so I am merging this, even while it lowers the coverage. Ideas are welcome. |
kernc
reviewed
Nov 10, 2016
| @@ -1,2 +0,0 @@ | |||
| import Orange.misc | |||
| psycopg2 = Orange.misc.import_late_warning("psycopg2") | |||
There was a problem hiding this comment.
Since this change, import_late_warning is used nowhere.
We could test if at least one of the backends is available and warn if none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backends moved to a separate package, moving backend-specific code from SqlTable/widgets to the appropriate backend