[FIX] Do not show messages when data is removed #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.86% (diff: 100%)@@ master #1706 diff @@
==========================================
Files 82 82
Lines 8802 8802
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7822 7822
Misses 980 980
Partials 0 0
|
lanzagar
approved these changes
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Some widgets retain (error, warning, info) messages event hough data is removed from the input.
When widgets receive None, any warning should go off (use Titanic and Distances to reproduce).
Description of changes
The problem was found and solved for widgets: OWDataSampler, OWDistances, OWScatterPlot.
Includes