Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Vizrank indicators and filters #1746

Merged
merged 3 commits into from
Nov 18, 2016

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Nov 11, 2016

Vizrank for two attributes now also shows results in a single column, with comma-separated attribute names.

Vizrank now indicates the visualization quality with a bar at the bottom of each row.

Visualizations can be filtered.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Nov 11, 2016

Current coverage is 88.90% (diff: 100%)

Merging #1746 into master will not change coverage

@@             master      #1746   diff @@
==========================================
  Files            82         82          
  Lines          8845       8845          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7864       7864          
  Misses          981        981          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 8ea3088...bf1c6e7

@lanzagar
Copy link
Contributor

Try Sieve Diagram on "imports-85" data.
I am guessing (but could be wrong) that missing values result in nan scores which the sorting does not handle correctly.

@janezd
Copy link
Contributor Author

janezd commented Nov 15, 2016

@lanzagar, great catch, thanks. I fixed it.

Trying the same on Mosaic (unexpectedly) seems to work, but the top-ranked combination crashes the widget. I reported that; it doesn't belong to this PR.

@lanzagar
Copy link
Contributor

We should do some more testing with missing values for different vizranks (and elsewhere :))
But the stuff in this PR seems good to me, works, and the changes are very nice. So lets merge, start using them, and see if we can spot some more corner cases which can be improved.

@lanzagar lanzagar merged commit d16638e into biolab:master Nov 18, 2016
@janezd janezd deleted the vizrank-single-column branch April 5, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants