[FIX] TimeVariable: don't crash Data Table when reloading and Visualize ... #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
changed the title
Current coverage is 88.91% (diff: 100%)@@ master #1760 diff @@
==========================================
Files 82 82
Lines 8847 8847
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7866 7866
Misses 981 981
Partials 0 0
|
|
Can you perhaps reproduce the issue in a test and include that test in the PR? |
…tinuous Fixes biolab#1734 (comment) Traceback (most recent call last): File "/home/lan/dev/orange3/Orange/widgets/utils/itemmodels.py", line 1112, in data return coldesc.format(instance) File "/home/lan/dev/orange3/Orange/widgets/utils/itemmodels.py", line 863, in format_dense return str(instance[var]) File "/home/lan/dev/orange3/Orange/data/variable.py", line 166, in __str__ return self.variable.str_val(self) File "/home/lan/dev/orange3/Orange/data/variable.py", line 924, in repr_val return str(val) File "/home/lan/dev/orange3/Orange/data/variable.py", line 166, in __str__ return self.variable.str_val(self) ... RecursionError: maximum recursion depth exceeded while calling a Python object
|
|
astaric
approved these changes
Nov 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The issue was with DataTable widget with Visualize continuous values enabled and reloading a timevariable as numeric and back. Now seems to work.
Fixes #1734 (comment)
Includes