Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWTranspose: Show warning when table.X is empty #1845

Closed
wants to merge 1 commit into from

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Dec 29, 2016

Issue

OWTable crashed, when passed data table with no data (produced by OWTranspose).
To reproduce: transpose table that consists only of meta attributes and pass it to OWTable.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Dec 29, 2016

Current coverage is 89.20% (diff: 100%)

Merging #1845 into master will not change coverage

@@             master      #1845   diff @@
==========================================
  Files            86         86          
  Lines          9077       9077          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           8097       8097          
  Misses          980        980          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 48e7e1c...4eba600

@lanzagar
Copy link
Contributor

lanzagar commented Jan 3, 2017

I think this avoids a bug, but does not fix it.
Table.transpose should not create a one-dimensional metas array.

@lanzagar
Copy link
Contributor

lanzagar commented Jan 4, 2017

Not needed after #1855 was merged.

@lanzagar lanzagar closed this Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants