Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Tree: Fix crash when two attributes equal number of values #1928

Merged
merged 1 commit into from
Jan 17, 2017

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jan 17, 2017

When two attributes had an equal number of values, the test before binarization tried to compare instances of DiscreteVariable.

Includes
  • Code changes

@lanzagar lanzagar changed the title Tree: Fix crash when two attributes equal number of values [FIX] Tree: Fix crash when two attributes equal number of values Jan 17, 2017
@codecov-io
Copy link

codecov-io commented Jan 17, 2017

Current coverage is 89.27% (diff: 100%)

Merging #1928 into master will not change coverage

@@             master      #1928   diff @@
==========================================
  Files            86         86          
  Lines          9116       9116          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           8138       8138          
  Misses          978        978          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 463242d...16f6de3

@lanzagar lanzagar merged commit c3a6b16 into biolab:master Jan 17, 2017
@astaric astaric added this to the 3.3.11 milestone Jan 20, 2017
@janezd
Copy link
Contributor Author

janezd commented Jan 20, 2017

astaric pushed a commit that referenced this pull request Feb 3, 2017
[FIX] Tree: Fix crash when two attributes equal number of values
(cherry picked from commit c3a6b16)
@janezd janezd deleted the tree-eq-num-val-bin branch April 5, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants