[FIX] Highcharts: Fix freezing on Qt5 #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
force-pushed
the
fix-webengine-qt5
branch
from
1247eca
to
3b06868
Compare
Codecov Report
@@ Coverage Diff @@
## master #2015 +/- ##
==========================================
- Coverage 70.4% 66.18% -4.22%
==========================================
Files 343 343
Lines 54074 54087 +13
==========================================
- Hits 38070 35799 -2271
- Misses 16004 18288 +2284Continue to review full report at Codecov.
|
kernc
force-pushed
the
fix-webengine-qt5
branch
from
9162c84
to
45bf69e
Compare
kernc
changed the title
|
Tests still timeout on appveyor :( |
kernc
force-pushed
the
fix-webengine-qt5
branch
from
45bf69e
to
f20a92d
Compare
Before this change, the widget froze in _JSObjectChannel.send_object().
... and no longer a callable Qt property.
kernc
force-pushed
the
fix-webengine-qt5
branch
3 times, most recently
from
35ef964
to
71debec
Compare
kernc
force-pushed
the
fix-webengine-qt5
branch
from
71debec
to
9ce670f
Compare
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Feb 14, 2017
[FIX] Highcharts: Fix freezing on Qt5 (cherry picked from commit 5373929)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Highcharts froze on Qt5.
Description of changes
No longer freezes on Qt5 by passing a core object into JS by a different mechanism and at a different time.
Includes