[FIX] owpreprocess: Handle columns with only NaN values #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
+ Coverage 69.81% 69.82% +<.01%
==========================================
Files 315 315
Lines 53957 53962 +5
==========================================
+ Hits 37670 37678 +8
+ Misses 16287 16284 -3Continue to review full report at Codecov.
|
astaric
reviewed
Mar 3, 2017
| In case when all rows in a column are NaN then it throws that error. | ||
| GH-2064 | ||
| """ | ||
| table = Table( |
There was a problem hiding this comment.
If the same dataset is used in multiple tests, would you consider moving it to datasets?
ZeroDivisonError - Weights sum to zero, can't be normalized In case when all rows in a column are NaN then it throws that error. https://sentry.io/biolab/orange3/issues/227119466/ Add another except in try block and now it shows an error message in the widget.
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ZeroDivisonError - Weights sum to zero, can't be normalized
In case when all rows in a column are NaN then it throws that error.
https://sentry.io/biolab/orange3/issues/227119466/
Description of changes
Add another except in try block and now it shows an error message in the widget.
Includes