Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWDistributions: Fix binning of meta attributes #2068

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Mar 2, 2017

Issue

File -> Select columns -> Distributions

Load Iris, move one of the (continuous) attributes to meta attributes and select it in the Scatter plot. Instead of that attribute, the scatter plot shows the class.

The first problem is that the attribute was selected incorrectly - as the first attribute in domain + metas. When the grouping attribute was an ordinary attribute and the shown attribute a meta, this resulted in showing the grouping attributes.

The second problem is that discretization classes do not discretize meta attributes.

Description of changes

Construct the table for discretization so that the attribute that has to be discretized always appears as a normal attribute.

Includes
  • Code changes
  • Tests

@lanzagar lanzagar merged commit 2dcb66f into biolab:master Mar 3, 2017
@codecov-io
Copy link

Codecov Report

Merging #2068 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2068      +/-   ##
=========================================
+ Coverage   69.75%   69.8%   +0.04%     
=========================================
  Files         315     315              
  Lines       53925   53936      +11     
=========================================
+ Hits        37615   37648      +33     
+ Misses      16310   16288      -22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5cdb6...44d2e08. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants