Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Select Rows: "is defined" fails #2087

Merged
merged 4 commits into from
Mar 14, 2017
Merged

[FIX] Select Rows: "is defined" fails #2087

merged 4 commits into from
Mar 14, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Mar 9, 2017

Issue

The widget issues a warning "need more than 0 values to unpack".
Given a data set the widget would be able to select only instances where the value of some attributes are defined.
#2054
And third column in a row is not disabled when selected "is defined".

Description of changes

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Mar 9, 2017

Codecov Report

Merging #2087 into master will increase coverage by <.01%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master    #2087      +/-   ##
==========================================
+ Coverage   71.27%   71.27%   +<.01%     
==========================================
  Files         318      318              
  Lines       54247    54265      +18     
==========================================
+ Hits        38662    38676      +14     
- Misses      15585    15589       +4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352f051...7fa103f. Read the comment docs.

astaric and others added 4 commits March 14, 2017 11:59
When an empty cell in a QTableWidget is double clicked, it becomes
editable, which is confusing. Avoid this behavior by using an empty
QLabel as placeholder.
@astaric astaric merged commit c150327 into biolab:master Mar 14, 2017
@jerneju jerneju deleted the gh-2054-selectrows-isdefined branch April 20, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants