Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fitter: Properly delegate preprocessors #2093

Merged
merged 1 commit into from
Mar 10, 2017

Conversation

pavlin-policar
Copy link
Collaborator

@pavlin-policar pavlin-policar commented Mar 9, 2017

Issue

#2091

Includes
  • Code changes
  • Tests
  • Documentation

@pavlin-policar
Copy link
Collaborator Author

This also fixes most of the failing tests in #2092, except the ones that are related to the association rules widget, which isn't a fitter, so it isn't related to this.

@astaric astaric merged commit 8364ae8 into biolab:master Mar 10, 2017
@codecov-io
Copy link

Codecov Report

Merging #2093 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
+ Coverage   69.93%   69.94%   +<.01%     
==========================================
  Files         315      315              
  Lines       53981    53985       +4     
==========================================
+ Hits        37754    37758       +4     
  Misses      16227    16227

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1171fa9...cdf77bb. Read the comment docs.

@pavlin-policar pavlin-policar deleted the fix-fitter-preprocessors branch March 10, 2017 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants