[FIX] Rank: fixes creating Table with infinite numbers #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2168 +/- ##
==========================================
- Coverage 71.44% 70.63% -0.82%
==========================================
Files 268 318 +50
Lines 53093 54515 +1422
==========================================
+ Hits 37932 38505 +573
- Misses 15161 16010 +849Continue to review full report at Codecov.
|
lanzagar
reviewed
Mar 31, 2017
Orange/widgets/data/owrank.py
Outdated
| @@ -685,6 +685,7 @@ def create_scores_table(self, labels): | |||
| # Reshape to 2d array as Table does not like 1d arrays | |||
| feature_names = feature_names[:, None] | |||
|
|
|||
| scores = np.nan_to_num(np.array(scores, dtype=np.float64)) | |||
There was a problem hiding this comment.
scores was created a couple of lines higher and is already a np.array. Why not specify dtype at creation?
Sometimes Rank calculates infinite values. Those cannot be put in Table. https://sentry.io/biolab/orange3/issues/222918568/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes Rank calculates infinite values. Those cannot be put in Table.
https://sentry.io/biolab/orange3/issues/222918568/
Includes