[ENH] Improve support for HiDPI displays #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
high-dpi-icons
branch
from
9e6ebb6
to
8ffa7c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2325 +/- ##
==========================================
+ Coverage 73.87% 73.88% +0.01%
==========================================
Files 322 322
Lines 55835 55843 +8
==========================================
+ Hits 41248 41262 +14
+ Misses 14587 14581 -6 |
ales-erjavec
force-pushed
the
high-dpi-icons
branch
from
8ffa7c1
to
934171a
Compare
ales-erjavec
force-pushed
the
high-dpi-icons
branch
from
934171a
to
609861c
Compare
Enable high dpi icon pixmaps, avoid QIcon.pixmap calls in favor of direct QIcon.paint
Use a background item with the same shape on which to attach the QGraphicsDropShadowEffect. Using QGraphicsEffect on an any item QGraphicsItem makes it devicePixelRatio unaware.
ales-erjavec
force-pushed
the
high-dpi-icons
branch
from
609861c
to
e5045d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Parts of the canvas are unaware of QPaintDevice.devicePixelRatio.
Description of changes
Includes