[FIX] score.FCBF: don't segfault on continuous variables w/ <0 values #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, FCBF always computed contingency as if the variable was discrete. Now uses Orange's Discrete contingency, which discretizes as necessary. This should, hopefully, also fix segfault on OSX when all values are missing.
kernc
commented
May 30, 2017
| @@ -129,5 +129,13 @@ def test_fcbf(self): | |||
| scorer = FCBF() | |||
| weights = scorer(self.zoo, None) | |||
| found = [self.zoo.domain[attr].name for attr in reversed(weights.argsort()[-5:])] | |||
| reference = ['legs', 'backbone', 'toothed', 'hair', 'aquatic'] | |||
| reference = ['legs', 'milk', 'toothed', 'feathers', 'backbone'] | |||
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
- Coverage 73.29% 73.28% -0.01%
==========================================
Files 317 317
Lines 55474 55473 -1
==========================================
- Hits 40658 40655 -3
- Misses 14816 14818 +2 |
ales-erjavec
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1916
Description of changes
Previously, FCBF always computed contingency as if the variable were discrete. Now uses Orange's Discrete contingency, which discretizes as necessary.
This should, hopefully, also fix segfault on OSX when all values are missing.
Includes