[FIX] Logistic Regression: impute #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
- Coverage 74.31% 74.23% -0.08%
==========================================
Files 320 320
Lines 55798 55808 +10
==========================================
- Hits 41466 41431 -35
- Misses 14332 14377 +45 |
lanzagar
requested changes
Jun 16, 2017
Orange/base.py
Outdated
| self.domain = data.domain | ||
| model = self._fit_model(data) | ||
| model.data = data |
There was a problem hiding this comment.
Can we avoid this. We already have model.original_data below which we would like to get rid of.
Every model should not store the complete data set.
There was a problem hiding this comment.
Now fixed in a different way.
jerneju
changed the title
lanzagar
approved these changes
Jun 24, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes