[FIX] ROC Analysis: color support for more than 9 evaluation learners #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2394 +/- ##
==========================================
+ Coverage 73.88% 74.16% +0.27%
==========================================
Files 322 322
Lines 55832 55941 +109
==========================================
+ Hits 41250 41486 +236
+ Misses 14582 14455 -127 |
janezd
requested changes
Jun 16, 2017
| @@ -448,8 +448,7 @@ def _initialize(self, results): | |||
| names = ["#{}".format(i + 1) | |||
| for i in range(len(results.predicted))] | |||
|
|
|||
| self.colors = colorpalette.ColorPaletteGenerator( | |||
| len(names), colorbrewer.colorSchemes["qualitative"]["Dark2"]) | |||
| self.colors = colorpalette.ColorPaletteGenerator(len(names)) | |||
There was a problem hiding this comment.
The palette that we had before could have been chosen for a reason. It should be used if possible; switch to a more generic palette only if needed.
janezd
approved these changes
Jun 16, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes