[FIX] Select Rows: Removing Unused Values for Discrete Variables in Sparse Data #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikicc
force-pushed
the
fix-remove-unused-values-sparse
branch
from
b68b8c0
to
a85dddb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2452 +/- ##
==========================================
- Coverage 74.51% 74.49% -0.02%
==========================================
Files 321 321
Lines 56056 56055 -1
==========================================
- Hits 41769 41760 -9
- Misses 14287 14295 +8 |
nikicc
force-pushed
the
fix-remove-unused-values-sparse
branch
4 times, most recently
from
56aee9e
to
a2b2e92
Compare
nikicc
force-pushed
the
fix-remove-unused-values-sparse
branch
from
a2b2e92
to
103197d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When
remove unused featuresis checked in Select Rows and some discrete variable comes from sparse data, Orange crashes withAttributeError: ravel not founderror.The problem is in the
remove_unused_valuesmethod (Orange/preprocess/remove.py) which cannot handle sparse matrices.Issue: https://sentry.io/biolab/orange3/issues/269413491/
Description of changes
nanuniquefunction.nanuniquereturns unique values without missing (np.nan) values and works on sparse and dense matrices.remove_unused_valuesto usenanuniqueand hance support sparse discrete columns.Includes