[FIX] Change Variable Icons: Discrete -> Categorical, Continuous -> Numeric #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2477 +/- ##
==========================================
+ Coverage 74.49% 74.53% +0.04%
==========================================
Files 321 321
Lines 56013 56173 +160
==========================================
+ Hits 41725 41868 +143
- Misses 14288 14305 +17 |
|
grep |
nikicc
approved these changes
Jul 27, 2017
nikicc
changed the title
|
How did I miss those? Thanks... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Variable icons do not match names used in the File widget, which is usually where people set/check variable types now. Many places in Orange use the same icons and use various names inconsistently.
Proposal
We use:
Description of changes
Moving towards consistency will be a long (Sisyphean) struggle.
This PR makes the file widget consistent, using categorical (C) and numeric (N). It also updates the icons' tooltips. The same icons are used across all Orange.
If/When other labels and descriptions are found using different terms, they should be adapted to use the same names.
Includes