[FIX] Fix saving reports on Python 3.6 #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem may be caused by this change in Python: https://bugs.python.org/issue22995. |
Codecov Report
@@ Coverage Diff @@
## master #2584 +/- ##
==========================================
- Coverage 75.07% 75.06% -0.02%
==========================================
Files 327 327
Lines 57668 57668
==========================================
- Hits 43297 43289 -8
- Misses 14371 14379 +8 |
janezd
force-pushed
the
fix-report-pickle
branch
from
e3048d2
to
1caa813
Compare
|
Codecov/patch coverage failed in files unrelated to this PR. |
|
I have tested on "normal" python 3.6. Test passes, reports can be saved and loaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This is urgent. The current release is broken: Reports cannot be saved because
ReportItems(derived fromQStandardItem) can't be pickled.Description of changes
Add
ReportItem.__getnewargs__.I don't have Python 3.6 env on this machine so I ran tests from a bundle. Can somebody with "real" Python 3.6 check this?
Includes