Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Boxplot: Allow hiding labels #2654

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Oct 5, 2017

Issue

Fixes #2652.

Description of changes

Add a checkbox.

I would like to discuss the change (perhaps live) before merging. We will have many controls that we'll want to add to the widgets and for each we need to think whether it can be avoided, lest we end up where we were in Orange 2.

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar
Copy link
Contributor

I have been thinking about this for a long time. One option that comes to mind is eliding the labels and placing them diagonally. The other option is a legend, but again probably with eliding (tooltips can be helpful here).

To discuss.

@janezd janezd changed the title [RFC] Boxplot: Allow hiding labels [RFC] [ENH] Boxplot: Allow hiding labels Oct 5, 2017
@codecov-io
Copy link

Codecov Report

Merging #2654 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2654      +/-   ##
==========================================
+ Coverage   75.38%   75.39%   +<.01%     
==========================================
  Files         331      331              
  Lines       57857    57860       +3     
==========================================
+ Hits        43618    43621       +3     
  Misses      14239    14239

@astaric
Copy link
Member

astaric commented Oct 5, 2017

Let's add back tabs! :)

(or a little gear icon at the bottom of a widget which opens "advanced settings")

@janezd
Copy link
Contributor Author

janezd commented Oct 5, 2017

It's OK here, since the checkbox does not increase the height (in fact, numeric variables already had such an option, it's called "Annotate" there). But we'll probably eventually need a general approach for this.

Eliding mostly won't help, and diagonal positioning is excelishly ugly (imho).

Copy link
Contributor

@jerneju jerneju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any more comments and suggestions or this can be merged?

@janezd janezd changed the title [RFC] [ENH] Boxplot: Allow hiding labels [ENH] Boxplot: Allow hiding labels Oct 13, 2017
@jerneju jerneju merged commit 554f0c9 into biolab:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants