Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Silhouette plot rendering #2656

Merged
merged 2 commits into from
Oct 13, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue

Rendering issues due to QTBUG-55070:

screen shot 2017-10-06 at 11 56 48

Description of changes

Remove use of QGraphicsProxyWidget. Also tweak scene rect update which did not update properly when decreasing the bar height.

Includes
  • Code changes
  • Tests
  • Documentation

The scene rect was not adjusted properly when decreasing the bar size
height.
@codecov-io
Copy link

Codecov Report

Merging #2656 into master will decrease coverage by 0.01%.
The diff coverage is 67.74%.

@@            Coverage Diff             @@
##           master    #2656      +/-   ##
==========================================
- Coverage   75.45%   75.44%   -0.02%     
==========================================
  Files         331      331              
  Lines       57970    58022      +52     
==========================================
+ Hits        43742    43775      +33     
- Misses      14228    14247      +19

@janezd janezd merged commit 9157034 into biolab:master Oct 13, 2017
@ales-erjavec ales-erjavec deleted the fixes/silhouette-plot-proxy-widget branch November 14, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants