Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implement multi window editing #2820

Merged
merged 19 commits into from
May 11, 2018

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Dec 7, 2017

Issue

Canvas does not support multiple open windows/workflows.

Description of changes

Implement multi window/workflow editing.

  • CanvasMainWindow is responsible for creating and managing new instances. This is somewhat wrong and might be improved by implementing something like a controller/manager in the future.
  • Log and Help views should probably be moved to separate singleton instances?
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec changed the title [ENH] Implement multi window editing [WIP][ENH] Implement multi window editing Dec 8, 2017
@codecov-io
Copy link

codecov-io commented Dec 8, 2017

Codecov Report

Merging #2820 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2820      +/-   ##
==========================================
- Coverage   82.12%   81.66%   -0.46%     
==========================================
  Files         334      327       -7     
  Lines       57663    55786    -1877     
==========================================
- Hits        47354    45560    -1794     
+ Misses      10309    10226      -83

@ales-erjavec ales-erjavec changed the title [WIP][ENH] Implement multi window editing [ENH] Implement multi window editing Dec 8, 2017
@ales-erjavec ales-erjavec force-pushed the canvas/multiwindow branch 4 times, most recently from 501442e to fdc3941 Compare December 22, 2017 11:43
@ales-erjavec ales-erjavec force-pushed the canvas/multiwindow branch 3 times, most recently from 6938fdc to d2acc81 Compare January 3, 2018 14:26
@lanzagar lanzagar merged commit b478b6c into biolab:master May 11, 2018
@ales-erjavec ales-erjavec deleted the canvas/multiwindow branch May 15, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants