Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Windows installers: Python lookup #2827

Merged
merged 6 commits into from
Dec 22, 2017
Merged

[FIX] Windows installers: Python lookup #2827

merged 6 commits into from
Dec 22, 2017

Commits on Dec 14, 2017

  1. Fix python lookup in the windows installer 

    To find 32 bit python >= 3.5 it is necessary to add explicit -32 suffix
to the tag name (sys.winver - PEP 514)
    @ales-erjavec
    ales-erjavec committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    edb0f1d View commit details
    Browse the repository at this point in the history

  2. Reuse GetPythonInstall514 for anaconda query

    @ales-erjavec
    ales-erjavec committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    e18ceda View commit details
    Browse the repository at this point in the history

  3. Add some basic anaconda installed prefix validation

    @ales-erjavec
    ales-erjavec committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    bc27c96 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. Also layout activate.bat for the created conda env 

    Add a start menu shortcut for droping into the activated env.
    @ales-erjavec
    ales-erjavec committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    78a0b1c View commit details
    Browse the repository at this point in the history

  2. Remove the activate env start menu shortcut on uninstall

    @ales-erjavec
    ales-erjavec committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    4991cc3 View commit details
    Browse the repository at this point in the history

  3. Fix start menu shortcut uninstall step 

    Allow the nsis installer to save the selected folder name in the
registry
    @ales-erjavec
    ales-erjavec committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    058f0ea View commit details
    Browse the repository at this point in the history