Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] SPG Legend: Fix vertical spacing #2914

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

pavlin-policar
Copy link
Collaborator

Issue

Fixes #2683

Description of changes

Default vertical spacing is 6. Anything below 5 seems to mess up the spacing. 6 looks ok, so use that.

Screenshot of changes on same data from issue.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Feb 18, 2018

Codecov Report

Merging #2914 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2914      +/-   ##
=========================================
+ Coverage    82.1%   82.1%   +<.01%     
=========================================
  Files         328     328              
  Lines       56235   56234       -1     
=========================================
  Hits        46169   46169              
+ Misses      10066   10065       -1

@ajdapretnar
Copy link
Contributor

Fantastic fix!

@ajdapretnar ajdapretnar reopened this Feb 19, 2018
@ajdapretnar
Copy link
Contributor

Sorry, being an idiot here. Wanted to merge.

@ajdapretnar ajdapretnar merged commit aedbf79 into biolab:master Feb 19, 2018
@pavlin-policar pavlin-policar deleted the legend-vertical-spacing branch February 19, 2018 09:07
@lanzagar lanzagar added this to the 3.11 milestone Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants