Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Test and Score: Fix averaging over classes for binary scores #2918

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

PrimozGodec
Copy link
Contributor

Issue

Binary scores were evaluated with target class when no target class was selected

Description of changes

This PR is fixing binary scores to use weighted scoring when no target class is selected

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #2918 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2918      +/-   ##
==========================================
+ Coverage    82.1%   82.12%   +0.01%     
==========================================
  Files         328      328              
  Lines       56262    56283      +21     
==========================================
+ Hits        46194    46221      +27     
+ Misses      10068    10062       -6

@lanzagar lanzagar self-assigned this Feb 23, 2018
virginica_auc = float(w.view.model().item(0, 1).text())

self.assertIsNotNone(average_auc)
self.assertIsNotNone(versicolor_auc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is checking that the aucs are not None necessary?
If they would not be computed, the conversion to float would fail before this anyway.

@lanzagar lanzagar changed the title [FIX] Scores in Test and Score widget [FIX] Test and Score: Fix averaging over classes for binary scores Feb 23, 2018
@lanzagar lanzagar added this to the 3.11 milestone Feb 23, 2018
@lanzagar lanzagar merged commit c6511b6 into biolab:master Feb 23, 2018
@PrimozGodec PrimozGodec deleted the auc-fix branch February 23, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants