[FIX] WidgetManager: Schedule delayed deletion for managed OWWidgets #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... when the workflow is 'closed' (ie. discarded and replaced by the canvas main editor)
Codecov Report
@@ Coverage Diff @@
## master #2963 +/- ##
==========================================
- Coverage 81.86% 81.85% -0.01%
==========================================
Files 329 329
Lines 56785 56781 -4
==========================================
- Hits 46486 46480 -6
- Misses 10299 10301 +2 |
WidgetManager would fail to delete the widget if it was removed from the workflow model while in 'processing' state.
Make the condition when delayed deletion is enacted match the specification in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the canvas editor creates a new workflow (via New or Open actions) the old OWWidgets are not deleted (promptly or even ever), like they are when explicitly deleted from the workflow.
Description of changes
Call deleteLater for managed widgets when the whole workflow is discarded.
Includes