[ENH] statistics: Speed up countnans for sparse matrices #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, thank you, thank you! 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #2965 +/- ##
==========================================
+ Coverage 81.86% 81.86% +<.01%
==========================================
Files 329 329
Lines 56785 56787 +2
==========================================
+ Hits 46486 46488 +2
Misses 10299 10299 |
|
I was wondering would it make sense to turn off Remove unused features and Remove unused classes for sparse matrices? When you connect the data, this is on by default and it makes things a bit slow. |
ales-erjavec
force-pushed
the
stats-sparse-na
branch
from
8fa3eab
to
2e0f093
Compare
ales-erjavec
force-pushed
the
stats-sparse-na
branch
from
2e0f093
to
fba0fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Alleviates gh-2925
Description of changes
Includes