Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] canvas/add-ons: Add extra packages via a name input dialog #3006

Merged
merged 2 commits into from
Apr 17, 2018
Merged

[ENH] canvas/add-ons: Add extra packages via a name input dialog #3006

merged 2 commits into from
Apr 17, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Allow adding add-ons not listed in the default list.

Description of changes

Allow entry of extra add-ons/packages via a name entry dialog.

Includes
  • Code changes
  • Tests
  • Documentation

markotoplak
markotoplak approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@markotoplak markotoplak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you. I would only recommend moving then "Add more" button to either right of the search box or just under the add-on list.

@markotoplak markotoplak merged commit 46e25c3 into biolab:master Apr 17, 2018
@PrimozGodec
Copy link
Contributor

PrimozGodec commented Apr 17, 2018 •
edited
Loading

I also tested it. Well done. :)

@PrimozGodec PrimozGodec added this to the 3.13 milestone Apr 17, 2018
@ales-erjavec ales-erjavec deleted the canvas/addon-install-by-name branch April 24, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markotoplak markotoplak markotoplak approved these changes

@PrimozGodec PrimozGodec Awaiting requested review from PrimozGodec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.
3 participants
@ales-erjavec @PrimozGodec @markotoplak