[FIX] owdiscretize: Fix quadratic complexitiy in the n variables #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
fixes/owdiscretize-quadratic
branch
from
32fc5f5
to
18d5483
Compare
Codecov Report
@@ Coverage Diff @@
## master #3016 +/- ##
==========================================
+ Coverage 82.12% 82.12% +<.01%
==========================================
Files 334 334
Lines 57663 57659 -4
==========================================
+ Hits 47354 47355 +1
+ Misses 10309 10304 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Discretize widgets has quadratic complexity just in constructing the output domain.
Noticeable for instance on geo-gds360 dataset with the 'Leave numeric' default discretization and no individual variable overrides.
Description of changes
Remove the awkward linear search for the source variable in
discretized_varmethod.Includes