[FIX] BSD compatibility patch #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3061 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 335 335
Lines 57986 57986
=======================================
Hits 47774 47774
Misses 10212 10212 |
|
Although we don't really support BSD (not included in any of our test suites), I don't mind a few fixes if that is all it takes to make it work. I would not be surprised, however, if there are problems elsewhere too... Thanks for the patch! |
I've created the FreeBSD port for Orange. It launches fine, although I didn't test it in-depth. Yuri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes