[ENH] Edit Domain: Record transformations #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix setData and setItemData so they no longer clear all other roles for the item. NOTE: Setting an item via the 'python sequence' interface (`model[idx] = val`) still clears data for all roles.
Return False from data setter overides on failure.
ales-erjavec
force-pushed
the
oweditdomain-record-transformations
branch
from
0530d91
to
52071cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #3231 +/- ##
=========================================
- Coverage 82.82% 82.8% -0.02%
=========================================
Files 346 346
Lines 59629 60072 +443
=========================================
+ Hits 49385 49745 +360
- Misses 10244 10327 +83 |
ales-erjavec
force-pushed
the
oweditdomain-record-transformations
branch
from
498d7e4
to
68f9fc3
Compare
ales-erjavec
force-pushed
the
oweditdomain-record-transformations
branch
from
68f9fc3
to
7da1764
Compare
|
This is really nice and works so well. I vote for the inclusion into the upcoming release. @lanzagar |
|
I have updated documentation for the widget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Improve 'Edit Domain' widget.
Fixes gh-3188
Description of changes
Includes