[FIX] Fix OWWidget destruction #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message group instance contains a reference to the widget instance keeping the widget alive via the undo/redo stack.
ales-erjavec
force-pushed
the
fixes/mem-leaks
branch
from
e5d690a
to
cdcc886
Compare
|
Thank you, @ales-erjavec. It works. |
Codecov Report
@@ Coverage Diff @@
## master #3296 +/- ##
==========================================
- Coverage 82.57% 82.05% -0.52%
==========================================
Files 348 351 +3
Lines 61395 61872 +477
==========================================
+ Hits 50697 50772 +75
- Misses 10698 11100 +402 |
Avoid a ref cycle in a connection in the base widget (biolabgh-3206)
ales-erjavec
force-pushed
the
fixes/mem-leaks
branch
from
cdcc886
to
44ca7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Canvas framework keeps a reference to the OWWidget in the undo/redo stack even when the widget has been removed (ref gh-3206).
Description of changes
message_idto keep track of active messages not the group instance.Includes